Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Botkube version as a part of startup #1052

Merged
merged 2 commits into from
May 11, 2023

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented May 5, 2023

Description

Changes proposed in this pull request:

  • Report botkube version to remote config source

Testing

Related issue(s)

Relates to https://github.com/kubeshop/botkube-cloud/issues/304

@huseyinbabal huseyinbabal marked this pull request as ready for review May 9, 2023 10:10
@huseyinbabal huseyinbabal requested a review from a team May 9, 2023 10:10
@huseyinbabal huseyinbabal requested a review from PrasadG193 as a code owner May 9, 2023 10:10
@huseyinbabal huseyinbabal requested a review from josefkarasek May 9, 2023 10:10
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josefkarasek josefkarasek force-pushed the report-botkube-version branch from ddb683a to 6334345 Compare May 11, 2023 11:59
@huseyinbabal huseyinbabal merged commit 0c94e3e into kubeshop:main May 11, 2023
@huseyinbabal huseyinbabal deleted the report-botkube-version branch May 11, 2023 12:31
pkosiec pushed a commit to pkosiec/botkube that referenced this pull request May 11, 2023
pkosiec pushed a commit that referenced this pull request May 11, 2023
(cherry picked from commit 0c94e3e)
@pkosiec pkosiec added the enhancement New feature or request label May 12, 2023
@pkosiec pkosiec changed the title report botkube version Report Botkube version as a part of startup May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants